Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): GET /api/users/exists #54875

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat(api): GET /api/users/exists #54875

merged 3 commits into from
Jun 12, 2024
+108 −6

Conversation

ojeytonwilliams
Copy link
Contributor

  • feat(api): GET api/users/exists
  • refactor: DRY out usage of isProfane

Checklist:

Closes #54872

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner May 20, 2024 09:59
@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label May 20, 2024
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
moT01
moT01 reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good 👍

a) "allows" check by email

Yea, I noticed this. Do we want to support that?

b) Returns false if the validation fails

I think we would be fine with how this is.

If we don't want to fix either of those, it LGTM 🎉 I'm on the fence about supporting the email query. I don't think it's used, but the old API allows it - so maybe we should to be on the safe side. Also, it may come in handy.

ShaunSHamilton
ShaunSHamilton approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ShaunSHamilton ShaunSHamilton enabled auto-merge (squash) June 12, 2024 10:24
@ShaunSHamilton ShaunSHamilton merged commit 8bcf080 into freeCodeCamp:main Jun 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

Assignees
No one assigned
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /api/users/exists?username=...
3 participants
@ojeytonwilliams @moT01 @ShaunSHamilton