-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): GET /api/users/exists #54875
feat(api): GET /api/users/exists #54875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good 👍
a) "allows" check by email
Yea, I noticed this. Do we want to support that?
b) Returns false if the validation fails
I think we would be fine with how this is.
If we don't want to fix either of those, it LGTM 🎉 I'm on the fence about supporting the email query. I don't think it's used, but the old API allows it - so maybe we should to be on the safe side. Also, it may come in handy.
a5be904
to
a06a559
Compare
a06a559
to
e1beb90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Checklist:
main
branch of freeCodeCamp.Closes #54872