-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes about testing Gradle 8.8 builds with TestKit using older Gradle versions #29184
Conversation
95b9ee7
to
a31c367
Compare
a31c367
to
873b516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking this is the answer to #29000?
If yes, could you please make it explicit.
@@ -510,6 +510,12 @@ This is currently used by the [JVM test suite plugin](userguide/jvm_test_suite_p | |||
|
|||
See the [user manual](userguide/implementing_gradle_plugins_binary.html#custom_dependencies_blocks) to learn more about using this incubating feature. | |||
|
|||
#### Testing Gradle 8.8 builds with TestKit using older Gradle version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ We should not mention this in release notes since that's a potential breaking change. It belongs to the upgrade guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This happens because Gradle 8.7 and earlier versions set `org.gradle.native=false` for a test process. | ||
While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. | ||
|
||
To fix this issue, you should use Gradle 8.8 to run the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is that really the only option? In #29000 you list more options. IMO we should document them all here.
@@ -510,6 +510,12 @@ This is currently used by the [JVM test suite plugin](userguide/jvm_test_suite_p | |||
|
|||
See the [user manual](userguide/implementing_gradle_plugins_binary.html#custom_dependencies_blocks) to learn more about using this incubating feature. | |||
|
|||
#### Testing Gradle 8.8 builds with TestKit using older Gradle version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[[testing_gradle_8_8_build_with_test_kit]] | ||
==== Testing Gradle build with TestKit using older Gradle version | ||
|
||
Testing a Gradle 8.8 build with TestKit, when the version of Gradle used to run the tests is lower than 8.8, could result in problems with tested build like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing a Gradle 8.8 build with TestKit, when the version of Gradle used to run the tests is lower than 8.8, could result in problems with tested build like: | |
Testing a Gradle 8.8 build with <<test_kit.adoc#test_kit,TestKit>> when the version of Gradle used to run the tests is lower than 8.8, can result in problems such as: |
- File system watching not working | ||
|
||
This happens because Gradle 8.7 and earlier versions set `org.gradle.native=false` for a test process. | ||
While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. | |
While previous versions ignored that flag, Gradle 8.8 correctly reads the `org.gradle.native` flag, and thus disables native services. |
I've reverted the behavior of |
No description provided.