Prune some test worker dependencies #29217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move this forward? |
jvandort
force-pushed
the
jvandort/testing/prune-dependencies
branch
3 times, most recently
from
eb019ea
to
7cb355f
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
The eventual goal is for ForkedTestClasspathFactory to not need a hard-coded list of gradle modules for worker classpaths. We should be able to generate that automatically based on the real dependencies of the test worker's runtime classpath. This commit begins to clean up the dependency graph of the test classpath, removing some dependencies on Gradle modules and external dependencies that don't necessarily need to be there. There is still quite some work to do, but this starts the process.
jvandort
force-pushed
the
jvandort/testing/prune-dependencies
branch
from
7cb355f
to
fc494af
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
big-guy
reviewed
May 29, 2024
| sb.append(")"); | ||
| } | ||
|
|
||
| return sb.toString(); | ||
| } | ||
|
|
||
| // Can be replaced with String.join when workers are updated to run in JDK 8. | ||
| private static String join(Set<String> strings, String delimiter) { |
There was a problem hiding this comment.
What about CollectionUtils.join(...)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventual goal is for ForkedTestClasspathFactory to not need a hard-coded list of gradle modules for worker classpaths. We should be able to generate that automatically based on the real dependencies of the test worker's runtime classpath.
This commit begins to clean up the dependency graph of the test classpath, removing some dependencies on Gradle modules and external dependencies that don't necessarily need to be there. There is still quite some work to do, but this starts the process.
Reviewing cheatsheet
Before merging the PR, comments starting with