-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas: Chore clean up more betterer warnings #88010
Conversation
@@ -11,7 +11,7 @@ export const PanZoomHelp = ({}: StandardEditorProps<string, unknown, unknown, un | |||
|
|||
return ( | |||
<> | |||
<HorizontalGroup className={styles.hGroup}> | |||
<Stack direction="row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit less tidy but doesn't seem like a big deal.
@@ -3,276 +3,253 @@ import { css } from '@emotion/react'; | |||
import { GrafanaTheme2 } from '@grafana/data'; | |||
|
|||
export function getGlobalStyles(theme: GrafanaTheme2) { | |||
return css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the change I'm most worried about haha, but I think it should be ok.. but would appreciate a review of this (cc @adela-almasan 😬)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Would be nice to have someone more familiar with canvas take a look as well, but looks fine overall 😄
Clean up almost all of the remaining betterer issues
The last two files / betterer issues will require a bit more extensive refactor that I will follow-up with to get rid of canvas's barrel files
Related to #87477