Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-18107 fixed package name #8385

Merged
merged 1 commit into from
May 27, 2024
Merged

HHH-18107 fixed package name #8385

merged 1 commit into from
May 27, 2024

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented May 14, 2024

HHH-18107 fixed package name

@dk2k dk2k mentioned this pull request May 14, 2024
Closed
gavinking
gavinking reviewed May 15, 2024
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct, but I wonder if it's better to just rename the package to org.hibernate.ucp, since the name of the module is hibernate-ucp.

@dk2k
Copy link
Contributor Author

dk2k commented May 15, 2024

@quaff Please take a look at this PR

@quaff
Copy link
Contributor

quaff commented May 16, 2024

@quaff Please take a look at this PR

OK, I'll take a look, but I'm a contributor like you, You need official review from project member.

@beikov beikov merged commit 00cbec1 into hibernate:main May 27, 2024
20 of 21 checks passed
@beikov
Copy link
Contributor

beikov commented May 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinking gavinking gavinking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dk2k @quaff @beikov @gavinking