-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Monzo config reauth #117726
Open
JakeMartin-ICL
wants to merge
11
commits into
home-assistant:dev
Choose a base branch
from
JakeMartin-ICL:monzo-integration-add-config-reauth
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Monzo config reauth #117726
JakeMartin-ICL
wants to merge
11
commits into
home-assistant:dev
from
JakeMartin-ICL:monzo-integration-add-config-reauth
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeMartin-ICL
force-pushed
the
monzo-integration-add-config-reauth
branch
from
May 19, 2024 12:18
87e565a
to
0063b5d
Compare
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
20 tasks
JakeMartin-ICL
force-pushed
the
monzo-integration-add-config-reauth
branch
from
May 19, 2024 13:54
aadc966
to
9c0eedc
Compare
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
joostlek
reviewed
May 19, 2024
JakeMartin-ICL
force-pushed
the
monzo-integration-add-config-reauth
branch
from
May 19, 2024 15:17
4417dc3
to
79b73c2
Compare
MartinHjelmare
changed the title
Monzo integration: add config reauth
Add Monzo config reauth
May 19, 2024
allenporter
reviewed
May 21, 2024
allenporter
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, one minor test file suggestion.
Ok, to be clear just telling you what the norms are for this type of test in nearly every other integration. |
JakeMartin-ICL
force-pushed
the
monzo-integration-add-config-reauth
branch
from
May 28, 2024 11:22
79b73c2
to
9a7b5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added reauth config flow to the Monzo integration.
Dependency bump: #117730
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: