-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): fix asset grid keyboard navigation #9448
fix(web): fix asset grid keyboard navigation #9448
Conversation
This change removes the keydown binds in favor of the browser handling those respective keys. This also makes arrow keys work as expected. However, the element has to be focused first. Not sure how things like Google Photos get away with having an inner element scroll even though the element that receives the KeyboardEvent is the |
Think I figured it out. It's possible to focus on an element while the keyDown event handler runs, and so long as the event doesn't have Currently only PageDown/PageUp trigger the focus, to match the product that shall not be named, but once focus is given to the asset grid, arrow keys and home/end also work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for figuring that out!
Fixes #9446