Modification of CategoryEncoding example code #19735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code was not working with the previous version so made changes as required . Please find the tested https://colab.research.google.com/gist/keerthanakadiri/c36fb5b439494618462daba5698b69d5/categoryencoding.ipynb and do the needful . Thank you !
keerthanakadiri
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19735 +/- ##
=======================================
Coverage 78.53% 78.53%
=======================================
Files 498 498
Lines 45753 45753
Branches 8455 8455
=======================================
Hits 35933 35933
Misses 8086 8086
Partials 1734 1734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR! The fact that the code example didn't work was a bug -- I added a tensor conversion in the layer to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code was not working with the previous version so made changes as required . Please find the tested gist and do the needful . Thank you !