Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 19 #9856

Open
wants to merge 13 commits into
base: next
Choose a base branch
from
Open

Upgrade to React 19 #9856

wants to merge 13 commits into from

Conversation

djhi
Copy link
Contributor

@djhi djhi commented May 17, 2024

We want to estimate the things that break in react-admin when using React 19 (currently in Release Candidate). Depending on the React 19 release date, we may even make it a requirement for react-admin v5.

  • Make it build
  • Make it pass the tests
  • Fix storybook
    - [ ] Fix storybook source addon

@djhi djhi added RFR Ready For Review and removed WIP Work In Progress DNM Do Not Merge labels May 21, 2024
@smeng9
Copy link
Contributor

smeng9 commented May 23, 2024

Can you clarify a bit about

Depending on the React 19 release date, we may even make it a requirement for react-admin v5.

Does that mean if react 19 is released before 5.0 stable version, then react 18 will be dropped from 5.0 support?

@fzaninotto
Copy link
Member

Does that mean if react 19 is released before 5.0 stable version, then react 18 will be dropped from 5.0 support?

Yes. This allows us to use React 19 features without waiting for the next react-admin major (probably in 2 years from now).

@slax57 slax57 self-requested a review May 27, 2024 09:05
@djhi djhi added the DNM Do Not Merge label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do Not Merge RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants