-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster scanner metrics in metrics-v3 #19517
Merged
harshavardhana
merged 5 commits into
minio:master
from
anjalshireesh:metrics-v3-cluster-scanner
May 24, 2024
Merged
Add cluster scanner metrics in metrics-v3 #19517
harshavardhana
merged 5 commits into
minio:master
from
anjalshireesh:metrics-v3-cluster-scanner
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
approved these changes
Apr 17, 2024
vadmeste
reviewed
Apr 17, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
from
April 17, 2024 11:02
e5d518d
to
c543ff3
Compare
klauspost
reviewed
Apr 17, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
from
April 24, 2024 08:10
2990eef
to
10cd8f9
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
from
May 3, 2024 09:40
f7e5ffa
to
ac6e82d
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
3 times, most recently
from
May 14, 2024 08:58
d100efb
to
162ae33
Compare
shtripat
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PTAL at the conflicts @anjalshireesh |
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
from
May 23, 2024 08:04
713eb0d
to
7b2cb8e
Compare
endpoint: /minio/metrics/v3/cluster/scanner metrics: - bucket_scans_finished (counter) - bucket_scans_started (counter) - directories_scanned (counter) - last_activity_nano_seconds (gauge) - objects_scanned (counter) - versions_scanned (counter)
anjalshireesh
force-pushed
the
metrics-v3-cluster-scanner
branch
from
May 24, 2024 14:15
3649d87
to
541bfb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
endpoint: /minio/metrics/v3/cluster/scanner
metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
curl "http(s)://<host:port>/minio/metrics/v3/cluster/scanner"
should return the new cluster scanner related metrics
Types of changes
Checklist:
commit-id
orPR #
here)