fix(autocomplete): hide clear button with visibility: hidden

[chirokas]

Closes #

📝 Description

opacity: 0 causes the elements to be very transparent but users can still interact with them.

⛳️ Current behavior (updates)

20240514_160517.mp4

🚀 New behavior

20240514_160634.mp4

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• New Features
  • Enabled showing and hiding the AutoComplete Clear Button using CSS visibility settings.

[changeset-bot]

🦋 Changeset detected

Latest commit: 856ed1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2024 0:34am

[vercel]

@chirokas is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

This update introduces a patch for the @nextui-org/theme package, specifically targeting the AutoComplete component. The main change involves enhancing the CSS to allow the AutoComplete Clear Button to be shown or hidden using visibility settings. This is achieved by adding and modifying CSS classes to control the visibility state based on different conditions, such as hover states and screen sizes.

Changes

File Path	Change Summary
.changeset/calm-rockets-shop.md	Introduced a patch for @nextui-org/theme to manage AutoComplete Clear Button visibility via CSS
packages/core/theme/src/components/autocomplete.ts	Added "invisible" class and modified visibility settings for different states and screen sizes

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8988981 and 856ed1e.

Files selected for processing (2)

• .changeset/calm-rockets-shop.md (1 hunks)
• packages/core/theme/src/components/autocomplete.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• .changeset/calm-rockets-shop.md

Additional comments not posted (4)

packages/core/theme/src/components/autocomplete.ts (4)

17-17: The addition of the "invisible" class ensures that the clear button is not only invisible but also non-interactive. This aligns with the intended behavior described in the PR summary.

---

21-21: Changing "data-[visible=true]:visible" to "data-[visible=true]:invisible" ensures that the clear button is non-interactive when hidden, which aligns with the intended behavior.

---

24-24: Adding "sm:data-[visible=true]:invisible" ensures that the clear button is non-interactive on small screens when hidden, which aligns with the intended behavior.

---

26-26: Changing "sm:group-data-[hover=true]:data-[visible=true]:visible" to "sm:group-data-[hover=true]:data-[visible=true]:invisible" ensures that the clear button is non-interactive on small screens when hovered, which aligns with the intended behavior.

[wingkwong]

I'm wondering if we need to keep both at the same time.

[chirokas]

Visibility is an animatable property. However, the result looks terrible and gives a jarring effect. This is because it's a discrete animation.

A solution to this problem is to specify a transition on both visibility and opacity.