Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add NODE_RUN_PACKAGE_JSON_PATH env #53058

Merged
merged 1 commit into from
May 21, 2024
Merged

cli: add NODE_RUN_PACKAGE_JSON_PATH env #53058

merged 1 commit into from
May 21, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 19, 2024

This change adds a NODE_RUN_PACKAGE_JSON_PATH environment variable when it's executed with node --run. This is required for cli runners to know the context of the task they are running. More information can be found in the reference issue.

Ref: #52673

cc @nodejs/cpp-reviewers

@anonrig anonrig added the semver-minor PRs that contain new features and should be released in the next minor version. label May 19, 2024
@anonrig anonrig requested review from lemire and benjamingr May 19, 2024 13:57
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 19, 2024
@anonrig anonrig force-pushed the add-node-run-package-json-path branch from 6f6698a to 9a745c6 Compare May 19, 2024 13:58
@anonrig anonrig mentioned this pull request May 19, 2024
Open
benjamingr
benjamingr approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual code LGTM

Feature wise, this only makes sense if we support package.json being outside the current folder which we don't intentionally - which makes this feature kind of pointless imo?

@anonrig
Copy link
Member Author

anonrig commented May 19, 2024

Actual code LGTM

Feature wise, this only makes sense if we support package.json being outside the current folder which we don't intentionally - which makes this feature kind of pointless imo?

@benjamingr I'll open a follow up pull request to add that as well :-)

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59304/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 21, 2024

Would it make sense to mark this as dont-land- until the follow up PR lands? If the feature is not yet useful, it's probably more prudent to not expose it too early in case we realize we need to change it / we end up not needing it.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2aaeaa8 into nodejs:main May 21, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2aaeaa8

targos pushed a commit that referenced this pull request Jun 1, 2024
@anonrig @targos
cli: add NODE_RUN_PACKAGE_JSON_PATH env
cfcde78 
PR-URL: #53058
Refs: #52673
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@anonrig @lukins-cz
cli: add NODE_RUN_PACKAGE_JSON_PATH env
4159198 
PR-URL: nodejs#53058
Refs: nodejs#52673
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@benjamingr benjamingr benjamingr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@jasnell jasnell Awaiting requested review from jasnell

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@anonrig @nodejs-github-bot @aduh95 @lemire @benjamingr @RafaelGSS