-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: replace kPathSeparator
with std::filesystem
#53063
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
85b1a5a
to
3b9bb49
Compare
@@ -13,6 +13,7 @@ | |||
#include <unistd.h> | |||
#endif | |||
|
|||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems wrong to include a header without using it in the file. Shouldn't it be included in node_report.cc
?
@@ -3,6 +3,7 @@ | |||
|
|||
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |||
|
|||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -7,6 +7,7 @@ | |||
#error("This header can only be used when inspector is enabled") | |||
#endif | |||
|
|||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -57,6 +57,7 @@ | |||
#include <array> | |||
#include <atomic> | |||
#include <cstdint> | |||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -4,6 +4,7 @@ | |||
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |||
|
|||
#include <cinttypes> | |||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Error on Windows:
|
We don't need
kPathSeparator
anymore sincestd::filesystem::path::preferred_separator
exists.cc @nodejs/cpp-reviewers @nodejs/fs