perf(web): Convert image assets to webp & skip flaky tests
#5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antonjoel82
changed the title
webp & skip flaky tests
BiswaViraj
reviewed
May 20, 2024
There was a problem hiding this comment.
❓ question: I see this file is deleted but no replacement webp file is added.
Does it mean we are not using this image anywhere?
There was a problem hiding this comment.
That's correct! Sorry for not calling that out
|
@antonjoel82 Shall we merge this? |
@SokratisVidros Could I please get an approval? |
antonjoel82
changed the title
webp & skip flaky testswebp & skip flaky tests
BiswaViraj
approved these changes
May 20, 2024
SokratisVidros
requested review from
scopsy and
Cliftonz
and removed request for
a team
antonjoel82
changed the title
webp & skip flaky testswebp & skip flaky tests
denis-kralj-novu
pushed a commit
that referenced
this pull request
May 24, 2024
* perf: Change assets to webp, fix brand redirect * fix: Update new layout comp with webp
SokratisVidros
pushed a commit
that referenced
this pull request
May 27, 2024
* perf: Change assets to webp, fix brand redirect * fix: Update new layout comp with webp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
public/static/imagestowebpto massively reduce sizeValidation