-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove duplicate js-yaml
packages
#23422
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 24dd26f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Thank you @Phillip9587 for this PR. The two failing lint tasks are related to a limitation in the You also need to rebase with the latest pnpm-lock file changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency-checks
rule is failing with alias dependencies. This should be resolved elsewhere.
Just include the override in the ignoredDependencies
to get this PR over the line and we will address this issue separately.
ab27d6d
to
fb74c0a
Compare
@meeroslav Done. I created #23469 to track the issue with the lint rule |
Thank you! Merging it in as soon as the build it green. |
@meeroslav CI is finally green |
Hello! May I inquire why Nx is using the package from zkochan vs the official package? We are using Any insight for the differences would be appreciated! Thank you! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
nx
package depends on bothjs-yaml
and@zkochan/js-yaml
Expected Behavior
nx
should only depend on one of the bothRelated Issue(s)
Fixes #