Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3775: add tests for CMO collection profiles #28768

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 5, 2024

The tests cover the following cases:

  • Apply every collection profile, and check if the expected
    ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if appropriate metrics are
    available (or unavailable).
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
Copy link
Contributor

openshift-ci bot commented May 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented May 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if the expected
    ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod rexagod marked this pull request as ready for review May 5, 2024 23:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@openshift-ci openshift-ci bot requested review from sjenning and soltysh May 5, 2024 23:10
@rexagod rexagod marked this pull request as draft May 6, 2024 01:13
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod marked this pull request as ready for review May 7, 2024 19:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested a review from p0lyn0mial May 7, 2024 19:21
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod changed the title MON-3775: add tests for CMO collection profiles MON-3775: [WIP] add tests for CMO collection profiles May 7, 2024
@rexagod rexagod marked this pull request as draft May 8, 2024 01:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: e449b02

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
[sig-network-edge][Feature:Idling] Unidling [apigroup:apps.openshift.io][apigroup:route.openshift.io] should handle many TCP connections by possibly dropping those over a certain bound [Serial] [Suite:openshift/conformance/serial]
This test has passed 98.57% of 70 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-serial' 'periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@rexagod rexagod marked this pull request as ready for review May 28, 2024 08:10
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: a0a9fc1

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-marketplace
This test has passed 99.89% of 4576 runs on release 4.17 [Overall] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.89% of 4576 runs on release 4.17 [Overall] in the last week.

@rexagod rexagod force-pushed the 3775 branch 3 times, most recently from 97d386a to 62cbbbb Compare May 30, 2024 07:47
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 62cbbbb

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 99.92% of 4719 runs on release 4.17 [Overall] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.98% of 4730 runs on release 4.17 [Overall] in the last week.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 060391d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.98% of 4946 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (102) are below the historical average (2015): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@rexagod
Copy link
Member Author

rexagod commented Jun 1, 2024

/pj-rehearse periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-techpreview

@rexagod
Copy link
Member Author

rexagod commented Jun 1, 2024

/test e2e-gcp-ovn-techpreview

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Jun 2, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2024
@rexagod rexagod changed the title MON-3775: [WIP] add tests for CMO collection profiles MON-3775: add tests for CMO collection profiles Jun 2, 2024
@rexagod
Copy link
Member Author

rexagod commented Jun 2, 2024

Ah, it seems monitortests are not intended for techpreview features?

ClusterStabilityDuringTest: monitortestframework.Stable,

@rexagod rexagod marked this pull request as draft June 2, 2024 05:39
@rexagod rexagod marked this pull request as draft June 2, 2024 05:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2024
)

const (
testName = "[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] Monitoring collection profiles have all service monitor counterparts present"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rexagod rexagod force-pushed the 3775 branch 2 times, most recently from 6ceec57 to 2b6dd3b Compare June 2, 2024 13:20
@rexagod rexagod marked this pull request as ready for review June 2, 2024 13:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2024
@rexagod
Copy link
Member Author

rexagod commented Jun 2, 2024

/test e2e-gcp-ovn-techpreview

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 2b6dd3b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial High
[sig-arch] events should not repeat pathologically for ns/openshift-dns
This test has passed 100.00% of 48 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.
---
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 100.00% of 48 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Low
[bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.

Open Bugs
openshift-apiserver ClusterOperator should not blip Available=False on brief missing HTTP content-type
---
[bz-Storage] clusteroperator/storage should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-Storage] clusteroperator/csi-snapshot-controller should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
Showing 4 of 6 test results

Copy link
Contributor

openshift-ci bot commented Jun 2, 2024

@rexagod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify da345ab link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants