Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Submodule] Remove third-party QNNPACK #126657

Closed
wants to merge 1 commit into from
Closed

[Submodule] Remove third-party QNNPACK #126657

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 19, 2024 •
edited

QNNPACK has integrated into ATEN for a long time and removing it from third party causing no build issue.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 19, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126657

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1663746 with merge base 574ae9a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 19, 2024
@cyyever cyyever marked this pull request as draft May 19, 2024 23:19
@cyyever cyyever added topic: deprecation topic category ciflow/binaries Trigger all binary build and upload jobs on the PR labels May 20, 2024
@cyyever cyyever marked this pull request as ready for review May 20, 2024 05:22
@cyyever cyyever requested review from malfet and ezyang May 20, 2024 05:22
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 20, 2024
@ezyang
Copy link
Contributor

ezyang commented May 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-rocm6_0-shared-with-deps-pre-cxx11-test

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented May 21, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: linux-binary-libtorch-pre-cxx11 / libtorch-rocm6_0-shared-with-deps-pre-cxx11-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever changed the title Remove QNNPACK submodule [Submodule] Remove QNNPACK submodule May 21, 2024
@cyyever cyyever changed the title [Submodule] Remove QNNPACK submodule [Submodule] Remove third-party QNNPACK May 21, 2024
@cyyever cyyever mentioned this pull request May 23, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request May 24, 2024
@cyyever @pytorchmergebot
[Submodule] Clear USE_QNNPACK build option (#126941)
95e5c99 
Following the removal of QNNPACK third-party module #126657, we can clear more build system code. Also third_party/neon2sse was removed because it is not used.
Pull Request resolved: #126941
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the qnnpack_module branch May 24, 2024 02:36
titaiwangms pushed a commit to titaiwangms/pytorch that referenced this pull request May 28, 2024
@cyyever @titaiwangms
[Submodule] Clear USE_QNNPACK build option (pytorch#126941)
8fb7b37 
Following the removal of QNNPACK third-party module pytorch#126657, we can clear more build system code. Also third_party/neon2sse was removed because it is not used.
Pull Request resolved: pytorch#126941
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: deprecation topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyyever @ezyang @pytorchmergebot @pytorchbot @drisspg