[dynamo] Allow asserts to fail

[peterbell10]

Stack from ghstack (oldest at bottom):

• -> [dynamo] Allow asserts to fail #126661

Currently if an assertion is statically known to be false, dynamo converts it to
_assert_async which inductor currently ignores. Instead this graph breaks to
raise the original assertion.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126661

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5b077ba with merge base 5fb11cd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[lezcano]

I don't like this one. I think it should be:

• If we can prove that it's true or false, then act accordingly.
• Otherwise, process it as runtime assert

This way we can use asserts to add facts to our knowledge base (shape env).

cc @ezyang

[peterbell10]

If we can prove that it's true or false, then act accordingly.

That's what this does. If we statically know it's false then we graph break and let python raise the exception.

[ezyang]

Yeah, this LGTM, thanks @peterbell10

[ezyang]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[lezcano]

uh, sorry, I had misread the code. I thought this was also handling the expression being equal to None.