-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prolog syntax highlighting #2848
base: master
Are you sure you want to change the base?
Conversation
Thank you. Can you look into getting the CI tests to pass? (add changelog entry, look into license check) |
There are 3 Failing tests:
|
Agreed.
Editing .sublime-syntax only is fine, thank you!
@Enselic Any idea how we could resolve this? |
Maybe we could try to use cargo deny for license checks. I use it in other projects and it is more sophisticated than our custom solution. Unsure if it supports submodules though. If that doesn't work, I think we simply have to make our own check more sophisticated. |
Hey, is there any chance moving this forward? i.e. would it be an option to add this file to the excluded files? |
I think adding a general exception to MPL is a better approach, but since I think this syntax would be the first MPL syntax, I don't want to approve that myself. New licenses in bat needs to be approved by sharkdp in my view. |
I found this Prolog Syntax definition and added it to bat. It is under MPL, so I added support for generating Acknowledgement for that license. Feel-free to double-check the legal part.
I had a bit of a hard time creating this PR because much of the tooling in this repo relies on the
bat
-binary in$PATH
instead of the locally built one. This was troubling when using my own acknowledgement code, as well as when generating the syntax test. I ended up hard-coding the path of the binary into the scripts (which I didn't submit for obvious reasons). I'm mentioning this in case anyone runs into the same problem.Fixes #1409