Flyway auto-configuration does not work with Flyway 10 when using GraalVM #40821
Conversation
2. Add test for flyway10 case
spring-projects-issues
added
the
status: waiting-for-triage
MazizEsa
changed the title
MazizEsa
changed the title
There was a problem hiding this comment.
Thanks, @MazizEsa.
In addition to my comment about avoiding reflection with Flyway 9. FlywayAutoConfiguration.FlywayAutoConfigurationRuntimeHints also needs to be updated to allow a Scanner instance to be created reflectively when using Flyway 10. This reflection hint should only be registered when a class that only exists in Flyway 10 is on the classpath.
| Constructor<?> scannerConstructor; | ||
| Scanner scanner; | ||
| try { | ||
| scannerConstructor = ClassUtils.forName("org.flywaydb.core.internal.scanner.Scanner", null) |
There was a problem hiding this comment.
I think it would be better to avoid reflection in the default case when using Flyway 9.
One way to do that would be to catch the NoSuchMethodError and then fall back to reflection. That fallback could even just assume that it's Flyway 10 and assume that Scanner will take 5 constructor arguments.
…lyway10 via reflection.
wilkinsona
changed the title
wilkinsona
added
type: bug
|
Thank you, @MazizEsa, and congratulations on making your first contribution to Spring Boot. |
|
Thanks @wilkinsona for polishing up. My apologies towards the end, I got busier with my work, hence slower in the implementation. |
In summary added compatibility with flyway 10 using reflection when initializing flyway scanner.
Add mechanism to check the dependency based on the mentioned flyway versions.
For #38923