Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link-adapter): allow configuration of magic link expiry #3671

Closed
wants to merge 0 commits into from

Conversation

omikader
Copy link
Contributor

This PR makes it so that users can configure how long they want the magic link to be valid for, in minutes. Right now the default value is 10, which is preserved if a value is not explicitly provided going forward.

Resolves this issue raised in the Discord

Copy link

changeset-bot bot commented Feb 14, 2024

⚠️ No Changeset found

Latest commit: 5caf568

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayair
Copy link
Contributor

jayair commented Feb 15, 2024

Thanks!

@jayair
Copy link
Contributor

jayair commented Feb 15, 2024

Taking a look.

@omikader
Copy link
Contributor Author

@jayair thanks!

One thing I thought about doing was changing it to accept an SST duration, e.g. "10 minutes" or "2 days" but I didn't want to bring in CDK dependencies into the node modules, even though they're technically available.

Lemme know what you or Dax prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants