navbar_alerts: Convert module to TypeScript.

[afeefuddin]

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

• Explains differences from previous plans (e.g., issue description).
• Highlights technical choices and bugs encountered.
• Calls out remaining decisions and concerns.
• Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

• Each commit is a coherent idea.
• Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[afeefuddin]

Should we remove this code and just use realm.demo_organization_scheduled_deletion_date! * 1000 ?

[timabbott]

I'm not sure I understand the question? Or the choice to remove the new Date() wrapper?

Oh, is the idea that we'd just be subtracting UNIX timestamps?

[afeefuddin]

Yes, that's what I meant. Should we do that, or is this just fine?

[timabbott]

Subtracting UNIX timestamps seems fine. But I don't like doing that in the same commit as the TS migration; it is very hard to check, and it seems like there's logic changes in multiple places in this file around adding/removing getTime calls. So maybe you can split that to a prep commit or follow-up commit to make those logic changes easier to review?

[andersk]

What justifies the unchecked !? There’s nothing that would prevent someone from changing code elsewhere to call this function while realm.demo_organization_scheduled_deletion_date is undefined, so this is not locally safe. Use assert instead.

[afeefuddin]

Done.

[afeefuddin]

The cancelled check seems unrelated.