-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
left_sidebar: Align more-topics indicator on topic grid. #30127
Conversation
7b19d40
to
9705c97
Compare
@@ -337,7 +337,7 @@ export function initialize({ | |||
}): void { | |||
$("#stream_filters").on( | |||
"click", | |||
".sidebar-topic-check, .topic-name, .topic-markers-and-controls", | |||
".sidebar-topic-check, .sidebar-topic-name, .topic-markers-and-controls", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line in topic_popover.js
looks like it might need to also be updated, with some care around how the popover is also declared for .inbox-row .inbox-topic-menu
url = $elt.closest("li").find(".topic-name").expectOne().prop("href");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. The if (instance.reference.classList.contains("inbox-topic-menu"))
conditional appears to isolate the line you pointed out safely from the Inbox popover, and manual testing confirms that. But maybe there's something else I'm overlooking where I'm not exercising due care?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, yes, quite so, reading the code to notice that block is the "some care" required :)
9705c97
to
eeb921a
Compare
Merged, thanks @karlstolley! |
This PR gets the
.searching-for-more-topics
indicator participating in the same grid used on other topic rows. A prep commit just flattens a selector in the area.CZO discussion
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: